Remove is-interactive, inline the TTY check#7198
Merged
ryancbahan merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
ryancbahan
changed the title
This was referenced Apr 3, 2026
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
gonzaloriestra
approved these changes
Apr 6, 2026
isaacroldan
approved these changes
Apr 7, 2026
The package was a 6-line function checking process.stdout.isTTY, TERM !== 'dumb', and absence of CI env var. Inline the logic directly in isTerminalInteractive(). Added 5 tests covering all branches: TTY + normal term, non-TTY, dumb terminal, CI set, CI empty string. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ryancbahan
changed the base branch from
04-03-04-03-remove-http-proxy
to
graphite-base/7198
ryancbahan
force-pushed
the
graphite-base/7198
branch
from
383b392 to
0146752
Compare
ryancbahan
force-pushed
the
04-03-04-03-remove-is-interactive
branch
from
dcd4b2d to
5e3d785
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is-interactivepackage with inline logic:process.stdout.isTTY && TERM !== 'dumb' && !CIisTTYis a Node.js built-in available on all platformsTest plan
tsc --noEmitpasses